> The parsed expressions are already cached. I don't think there is any scope > for further caching here.
Parsed expressions are cached as org.apache.el.parser.Node instances (in ExpressionBuilder#createNodeInternal) - if I understood correctly. What I was think was to cache javax.el.ValueExpression instances, but not sure if it's correct to cache those instances (what's scope ?). For instance, in a jsp compiled code, we have multiple calls to PageContextImpl.proprietaryEvaluate. proprietaryEvaluate calls createValueExpression and getValue. In a sample * 28% of proprietaryEvaluate time is spent on createValueExpression, * 45% is spent on getValue ----- Mail original ----- De : Mark Thomas <ma...@apache.org> À : Tomcat Users List <users@tomcat.apache.org> Cc : Envoyé le : Jeudi 8 Septembre 2011 11h28 Objet : Re: Re : Re : Re : Performance issue in simpleTags and tagfiles On 08/09/2011 09:59, Adrian Gonzalez wrote: > Just downloaded JProfiler eval. > > Compared tagfile performance between 7.0.21 and 7.0.trunk (this one this time > : http://svn.apache.org/repos/asf/tomcat/tc7.0.x/trunk/) > > With your optimization, we achieve a 24% performance gain - nice ;) > > Test 7.0.21 7.0.trunk > tagfile 267ms 206ms > > You can see JConsole output > * 7.0.21 : http://imageshack.us/photo/my-images/233/tagperftagfile7021.jpg/ > * 7.0.trunk : >http://imageshack.us/photo/my-images/52/tagperftagfile70trunk.jpg/ > > Tests were made with > http://localhost:8080/tagfilesperf/generated/edit-tagfile.jsp > > > One more question though : > Do you think we can cache ValueExpression instances ? The parsed expressions are already cached. I don't think there is any scope for further caching here. I'll take another look with the profiler just to be sure. Mark --------------------------------------------------------------------- To unsubscribe, e-mail: users-unsubscr...@tomcat.apache.org For additional commands, e-mail: users-h...@tomcat.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: users-unsubscr...@tomcat.apache.org For additional commands, e-mail: users-h...@tomcat.apache.org
