Dear Kyle Moffett, In message <1318971929-1160-1-git-send-email-kyle.d.moff...@boeing.com> you wrote: > This is a reposted patch series from several months that enhances the > e1000 driver in U-Boot to support the Intel 82571EB and provides > several new features for the board manufacturing process. > > Based on prior review, the EEPROM programming and SPI code has been > moved into a separate file, "e1000_spi.c", and it calls a few exported > functions in the main e1000.c file to coordinate EEPROM access. > > Comments, critiques, and compliments are highly appreciated.
Critique: I wonder how you tested your patches, if at all :-( They generate a ton of warnings: e1000.c: In function 'e1000_raise_ee_clk': e1000.c:155: warning: unused variable 'x' e1000.c: In function 'e1000_lower_ee_clk': e1000.c:172: warning: unused variable 'x' e1000.c: In function 'e1000_shift_out_ee_bits': e1000.c:208: warning: unused variable 'x' e1000.c: In function 'e1000_standby_eeprom': e1000.c:279: warning: unused variable 'x' e1000.c:285: warning: unused variable 'x' e1000.c:291: warning: unused variable 'x' e1000.c:297: warning: unused variable 'x' e1000.c:303: warning: unused variable 'x' e1000.c:307: warning: unused variable 'x' e1000.c: In function 'e1000_release_eeprom': e1000.c:689: warning: unused variable 'x' e1000.c:695: warning: unused variable 'x' e1000.c: In function 'e1000_reset_hw': e1000.c:1401: warning: unused variable 'x' e1000.c:1428: warning: unused variable 'x' e1000.c: In function 'e1000_init_hw': e1000.c:1635: warning: unused variable 'x' e1000.c:1647: warning: unused variable 'x' e1000.c:1661: warning: unused variable 'x' e1000.c: In function 'e1000_setup_fiber_link': e1000.c:2029: warning: unused variable 'x' e1000.c: In function 'e1000_config_collision_dist': e1000.c:3235: warning: unused variable 'x' e1000.c: In function 'e1000_raise_mdi_clk': e1000.c:3960: warning: unused variable 'x' e1000.c: In function 'e1000_lower_mdi_clk': e1000.c:3977: warning: unused variable 'x' e1000.c: In function 'e1000_shift_out_mdi_bits': e1000.c:4020: warning: unused variable 'x' e1000.c: In function 'e1000_shift_in_mdi_bits': e1000.c:4059: warning: unused variable 'x' e1000.c: In function 'e1000_phy_hw_reset': e1000.c:4341: warning: unused variable 'x' e1000.c:4349: warning: unused variable 'x' e1000.c:4362: warning: unused variable 'x' e1000.c:4366: warning: unused variable 'x' e1000.c: In function 'e1000_configure_rx': e1000.c:4991: warning: unused variable 'x' e1000.c: In function 'e1000_transmit': e1000.c:5049: warning: unused variable 'x' e1000.c: In function 'e1000_initialize': e1000.c:869: warning: 'checksum' may be used uninitialized in this function e1000.c:869: note: 'checksum' was declared here Please fix!!! Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de I am a computer. I am dumber than any human and smarter than any ad- ministrator. _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
