Dear Kyle Moffett, In message <[email protected]> you wrote: > By allocating the e1000 device structures much earlier, we can easily > generate better error messages and siginficantly clean things up. > > The only user-visable change (aside from reworded error messages) is > that a detected e1000 device which fails to initialize due to software > or hardware error will still be allocated a device number. > > As one example, consider a system with 2 e1000 PCI devices where the > first controller has a corrupted EEPROM. Using the old code the > second controller would be "e1000#0", while with this change it would be > "e1000#1". > > This change should hopefully make such EEPROM errors much more > straightforward to handle correctly in boot scripts and the like. > > It is also necessary for a followup patch which allows SPI programming > of an e1000 controller's EEPROM even if the checksum is invalid. > > Signed-off-by: Kyle Moffett <[email protected]> > Cc: Ben Warren <[email protected]> > > -- > > Changelog: > v2: Clean up error messages a bit more > > NOTE: This patch generates 3 false positives from checkpatch because > of the existing use of the ",##args" construct in the E1000 debug > macros to get rid of the "," when no arguments are passed. > > --- > drivers/net/e1000.c | 126 > +++++++++++++++++++++++++-------------------------- > drivers/net/e1000.h | 19 +++++--- > 2 files changed, 74 insertions(+), 71 deletions(-)
Applied, thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [email protected] Lots of people drink from the wrong bottle sometimes. -- Edith Keeler, "The City on the Edge of Forever", stardate unknown _______________________________________________ U-Boot mailing list [email protected] http://lists.denx.de/mailman/listinfo/u-boot
