> Commit 114d7fc0 "e1000: Rewrite EEPROM checksum error to give more > information" failed to initialize the checksum variable which should > result in random results. Fix that. > [I wonder if that code has _ever_ been tested!!] > > Commit 2326a94d caused a ton of "unused variable 'x'" warnings. > Fix these. While we are at it, remove some bogus parens. > > Signed-off-by: Wolfgang Denk <w...@denx.de> > Cc: Kyle Moffett <kyle.d.moff...@boeing.com> > --- > > Kyle, > > I wonder if you have ever actually build and run this code??? > With the "checksum" variable being random (due to not being > initialized) you should have seen serious checksum problems. > How did this escape your testing? > > And all these build warnings - have you ever actully compiled that > code? What's going on here??? - wd > > Marek: Could you please be so kind and have a look at the debug code? > I think this needs a major cleanup, too. Thanks in advance. - wd
I might take a sneak peek ... -mv _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
