On Wednesday 12 October 2011 12:11:23 Stephen Warren wrote:
> Mike Frysinger wrote at Wednesday, October 12, 2011 9:27 AM:
> > On Wednesday 12 October 2011 11:18:47 Stephen Warren wrote:
> > > --- /dev/null
> > > +++ b/board/nvidia/ventana/Makefile
> > > 
> > > +$(LIB):  $(obj).depend $(OBJS)
> > > + $(AR) $(ARFLAGS) $@ $(OBJS)
> > 
> > your build file is out of date.  this needs to use the cmd link target. 
> > seem just about any other board Makefile for an example.
> 
> Which repo/branch contains the updated files?
> 
> I'm using git://git.denx.de/u-boot.git master, and this new Makefile is
> identical to existing board/nvidia/{harmony,seaboard}/Makefile. I guess
> looking at some other board vendors though, you mean that I should make
> the following change:
> 
> $(LIB):       $(obj).depend $(OBJS)
> -     $(call cmd_link_o_target, $(OBJS))
> +     $(AR) $(ARFLAGS) $@ $(OBJS)

your patch is reverted :).  if other boards are using $(AR), it's because 
during review people didn't notice.  calling $(AR) is wrong now.  please post 
patches for those boards too :).

> > > +clean:
> > > + rm -f $(OBJS)
> > > +
> > > +distclean:       clean
> > > + rm -f $(LIB) core *.bak $(obj).depend
> > 
> > unused ... just punt them
> 
> These rules appear to be present in at least 80-90% of other board files.
> Has there simply not been a pass to remove them everywhere yet?

i've posted a big patch to do that already, but it hasn't yet been merged
-mike

Attachment: signature.asc
Description: This is a digitally signed message part.

_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Reply via email to