On Sun, Mar 2, 2025 at 1:53 PM Adam Ford <aford...@gmail.com> wrote:
> @@ -312,7 +313,17 @@ int mxc_serial_setbrg(struct udevice *dev, int baudrate)
> static int mxc_serial_probe(struct udevice *dev)
> {
> struct mxc_serial_plat *plat = dev_get_plat(dev);
> + int ret;
>
> +#if CONFIG_IS_ENABLED(CLK_CCF)
> + ret = clk_get_bulk(dev, &plat->clks);
> + if (ret)
> + return ret;
> +
> + ret = clk_enable_bulk(&plat->clks);
> + if (ret)
> + return ret;
> +#endif
CI fails when building a target with CLK_CCF disabled:
aarch64: + imx8mp_evk
+drivers/serial/serial_mxc.c: In function 'mxc_serial_probe':
+drivers/serial/serial_mxc.c:316:13: error: unused variable 'ret'
[-Werror=unused-variable]
+ 316 | int ret;
+ | ^~~
+cc1: all warnings being treated as errors
+make[4]: *** [scripts/Makefile.build:257:
spl/drivers/serial/serial_mxc.o] Error 1
+make[3]: *** [scripts/Makefile.build:398: spl/drivers/serial] Error 2
+make[2]: *** [scripts/Makefile.xpl:550: spl/drivers] Error 2
+make[1]: *** [Makefile:2117: spl/u-boot-spl] Error 2
+make: *** [Makefile:177: sub-make] Error 2
Please fix and resend.
