On 05/12/2011 08:13 AM, Jason Liu wrote: > Hi, Stefano, > Hi Jason,
>>> u32 get_cpu_rev(void); >>> #define is_soc_rev(rev) ((get_cpu_rev() & 0xFF) - rev) >>> void sdelay(unsigned long); >>> +void pmic_reg_write(u32 reg, u32 value); >>> +u32 pmic_reg_read(u32 reg); >> >> The pmic_ prototypes have nothing to do with the Soc prototype, as they >> are specific for a driver. You should move them in the dialog header. >> > > I think I need create one head file named: include/dlg_pmic.h to include the > pmic_reg_write/read declaration and not just put the declaration to > da9053.h file, what's your idea? You are right, I have only concerns to add a new file only to put three prototypes.... Anyway, it seems to me also a cleaner solution. However, the name of file should be general, as the prototypes are used for all PMICs using the SPI/I2C interfaces. Probably spi_i2c_pmic.h to stay coherent with the driver name. Best regards, Stefano Babic -- ===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: off...@denx.de ===================================================================== _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
