Hi, Stefano,
On Wed, May 11, 2011 at 8:37 PM, Stefano Babic <sba...@denx.de> wrote:
> On 05/11/2011 10:03 AM, Jason Liu wrote:
>> This patch add initial support for freescale MX53LOCO board.
>> Network(FEC),SD/MMC,UART have been supported by this patch
>>
>> The patch also config CPU:1GHZ,DDR:400MHZ for better peformance
>>
>> Signed-off-by: Jason Liu <jason....@linaro.org>
>
> Hi Jason,
>
>> diff --git a/arch/arm/cpu/armv7/mx5/soc.c b/arch/arm/cpu/armv7/mx5/soc.c
>> index 6f4e8db..9c03474 100644
>> --- a/arch/arm/cpu/armv7/mx5/soc.c
>> +++ b/arch/arm/cpu/armv7/mx5/soc.c
>> @@ -116,7 +116,7 @@ int print_cpuinfo(void)
>> (cpurev & 0x000F0) >> 4,
>> (cpurev & 0x0000F) >> 0,
>> mxc_get_clock(MXC_ARM_CLK) / 1000000);
>> - printf("Reset cause: %s\n", get_reset_cause());
>> + printf("Reset cause: %s\n", get_reset_cause());
>> return 0;
>
> It seems to me this file slips into your patch, but it was not supposed
> to be.
Yes, I will remove it.
>
>> }
>> #endif
>> diff --git a/arch/arm/include/asm/arch-mx5/sys_proto.h
>> b/arch/arm/include/asm/arch-mx5/sys_proto.h
>> index f687503..2d7e9ed 100644
>> --- a/arch/arm/include/asm/arch-mx5/sys_proto.h
>> +++ b/arch/arm/include/asm/arch-mx5/sys_proto.h
>> @@ -27,5 +27,7 @@
>> u32 get_cpu_rev(void);
>> #define is_soc_rev(rev) ((get_cpu_rev() & 0xFF) - rev)
>> void sdelay(unsigned long);
>> +void pmic_reg_write(u32 reg, u32 value);
>> +u32 pmic_reg_read(u32 reg);
>
> The pmic_ prototypes have nothing to do with the Soc prototype, as they
> are specific for a driver. You should move them in the dialog header.
OK,
>
>> +int board_init(void)
>> +{
>> + gd->bd->bi_arch_number = MACH_TYPE_MX53_LOCO;
>> + gd->bd->bi_boot_params = PHYS_SDRAM_1 + 0x100;
>> +
>> +#ifdef CONFIG_I2C_MXC
>> + setup_i2c(0);
>> + power_init();
>> + clock_init();
>> +#endif
>
> Probably it does not make a lot of sense to build this board without I2C
> support. If this is the case, you should drop the #ifdef, as your board
> must always be compiled with I2C.
OK,
Jason
>
> Best regards,
> Stefano Babic
>
> --
> =====================================================================
> DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: off...@denx.de
> =====================================================================
>
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
