Hi Martin, On 26/09/24 17:56, Martin Stolpe wrote: > Hi, > > Am Di., 24. Sept. 2024 um 08:38 Uhr schrieb Devarsh Thakkar > <devar...@ti.com <mailto:devar...@ti.com>>: > > > CONFIG_FDT_SIMPLEFB is only used in splash-screen context which in-turn > depends on CONFIG_VIDEO. So CONFIG_FDT_SIMPLEFB is in a way dependent on > CONFIG_VIDEO. We had fixed similar issue in past in vendor tree and > by making > CONFIG_FDT_SIMPLEFB dependent on CONFIG_VIDEO using below set of > patches [1] > which I was planning to post upstream too. > > Kindly let me know If these patches look good to you and fix your > problem too, > I can post same set of patches to upstream too. > > [1] : > > https://git.ti.com/cgit/ti-u-boot/ti-u-boot/commit/?h=ti-u-boot-2024.04&id=1199800505f11f2162030cb641c6d0c9276d5c9c > > <https://git.ti.com/cgit/ti-u-boot/ti-u-boot/commit/?h=ti-u-boot-2024.04&id=1199800505f11f2162030cb641c6d0c9276d5c9c> > [2] : > > https://git.ti.com/cgit/ti-u-boot/ti-u-boot/commit/?h=ti-u-boot-2024.04&id=5b4b8eac243cbd86286ff2cf57ca0469c4d86345 > > <https://git.ti.com/cgit/ti-u-boot/ti-u-boot/commit/?h=ti-u-boot-2024.04&id=5b4b8eac243cbd86286ff2cf57ca0469c4d86345> > > > These patches look good to me. >
Thanks for taking a look, I have posted them to the list [1], it would be great if you could provide a Reviewed-by or Tested-by too. > If I understand the code correctly the frame buffer node should only be > created if CONFIG_FDT_SIMPLEFB is enabled. Thus I would change the code > like this: > Yes, that's true, I think you also need to conditionally compile ft_board_setup only when CONFIG_OF_BOARD_SETUP is enabled. [1]: https://lore.kernel.org/all/20240925151354.480704-4-devar...@ti.com/ Regards Devarsh
