Hi, Am Fr., 20. Sept. 2024 um 10:10 Uhr schrieb Ivan T. Ivanov <iiva...@suse.de >:
> Hi, > > On 09-20 08:32, Martin Stolpe wrote: > > > > When the CONFIG_VIDEO option is set to disabled for Raspberry Pi devices > > the build will fail with the following error message: > > "undefined reference to `fdt_simplefb_enable_and_mem_rsv'." > > > > Signed-off-by: Martin Stolpe <martin.sto...@gmail.com> > > --- > > > > board/raspberrypi/rpi/rpi.c | 2 +- > > boot/fdt_simplefb.c | 2 +- > > 2 files changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/board/raspberrypi/rpi/rpi.c b/board/raspberrypi/rpi/rpi.c > > index ab5ea85cf9..bc49708f85 100644 > > --- a/board/raspberrypi/rpi/rpi.c > > +++ b/board/raspberrypi/rpi/rpi.c > > @@ -572,7 +572,7 @@ int ft_board_setup(void *blob, struct bd_info *bd) > > node = fdt_node_offset_by_compatible(blob, -1, > "simple-framebuffer"); > > if (node < 0) > > fdt_simplefb_add_node(blob); > > - else > > + else if (IS_ENABLED(CONFIG_VIDEO)) > > fdt_simplefb_enable_and_mem_rsv(blob); > > I think there is one more user of this function which end of same > situation stm32mp1. > Would it make sense to replace the config option CONFIG_FDT_SIMPLEFB with CONFIG_VIDEO? CONFIG_FDT_SIMPLEFB is only used in the Raspberry Pi default configurations but in no other board configuration and I don't see it being used in the code besides in stm32mp1.c. Regards Martin
