Hi Martin, Ivan On 24/09/24 11:56, Martin Stolpe wrote: > Hi, > > Am Fr., 20. Sept. 2024 um 10:10 Uhr schrieb Ivan T. Ivanov <iiva...@suse.de >> : > >> Hi, >> >> On 09-20 08:32, Martin Stolpe wrote: >>> >>> When the CONFIG_VIDEO option is set to disabled for Raspberry Pi devices >>> the build will fail with the following error message: >>> "undefined reference to `fdt_simplefb_enable_and_mem_rsv'." >>>
Thanks for the patch. >>> Signed-off-by: Martin Stolpe <martin.sto...@gmail.com> >>> --- >>> >>> board/raspberrypi/rpi/rpi.c | 2 +- >>> boot/fdt_simplefb.c | 2 +- >>> 2 files changed, 2 insertions(+), 2 deletions(-) >>> >>> diff --git a/board/raspberrypi/rpi/rpi.c b/board/raspberrypi/rpi/rpi.c >>> index ab5ea85cf9..bc49708f85 100644 >>> --- a/board/raspberrypi/rpi/rpi.c >>> +++ b/board/raspberrypi/rpi/rpi.c >>> @@ -572,7 +572,7 @@ int ft_board_setup(void *blob, struct bd_info *bd) >>> node = fdt_node_offset_by_compatible(blob, -1, >> "simple-framebuffer"); >>> if (node < 0) >>> fdt_simplefb_add_node(blob); >>> - else >>> + else if (IS_ENABLED(CONFIG_VIDEO)) >>> fdt_simplefb_enable_and_mem_rsv(blob); >> >> I think there is one more user of this function which end of same >> situation stm32mp1. >> > > Would it make sense to replace the config option CONFIG_FDT_SIMPLEFB with > CONFIG_VIDEO? CONFIG_FDT_SIMPLEFB is only used in the Raspberry Pi default > configurations but in no other board configuration and I don't see it being > used in the code besides in stm32mp1.c. > CONFIG_FDT_SIMPLEFB is only used in splash-screen context which in-turn depends on CONFIG_VIDEO. So CONFIG_FDT_SIMPLEFB is in a way dependent on CONFIG_VIDEO. We had fixed similar issue in past in vendor tree and by making CONFIG_FDT_SIMPLEFB dependent on CONFIG_VIDEO using below set of patches [1] which I was planning to post upstream too. Kindly let me know If these patches look good to you and fix your problem too, I can post same set of patches to upstream too. [1] : https://git.ti.com/cgit/ti-u-boot/ti-u-boot/commit/?h=ti-u-boot-2024.04&id=1199800505f11f2162030cb641c6d0c9276d5c9c [2] : https://git.ti.com/cgit/ti-u-boot/ti-u-boot/commit/?h=ti-u-boot-2024.04&id=5b4b8eac243cbd86286ff2cf57ca0469c4d86345 Regards Devarsh > Regards > Martin >
