Dear Joe XUE, In message <snt105-w339861012ab3a9edcc0ddaac...@phx.gbl> you wrote: > > > > Signed-off-by: Joe Xue <lg...@hotmail.com> > > > > > > > Please add a version number to your patch to make easier tracking which > > is your last version. > > > Will add it. > > Do not forget to add always the net Maintainer to CC (Wolfgang Denk), I > > added him now. > > > Not exactly understand your meaning. You mean I should add wd as maintainer > to my code or just add him in mail.
Only email, please. An easy way to not forget this is to add a "Cc:" line below your Signed-off-by: line - then "git send-email" will automatically generate the needed Cc:s > > > +static void ax88783_halt(struct eth_device *dev) > > > +{ > > > + unsigned int tmp; > > > + struct ax88783_reg *reg = (struct ax88783_reg *)dev->iobase; > > > + tmp = readl(®->pcr); > > > + writel((tmp | PCR_LOOP_BACK), ®->pcr); > > > +} > > > > From the name it seems you set the controller in loopback, instead of > > disabling it. Is it correct ? > > > mmn. I just make it can't receive the data outside.The other way is make it > into sleep mode. Please put it in sleep mode, then. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Most legends have their basis in facts. -- Kirk, "And The Children Shall Lead", stardate 5029.5 _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot