Dear Albin Tonnerre,
In message <aanlktimaci9vyr8hpnq99wnjzowkniqgy7oxk_vr0...@mail.gmail.com> you
wrote:
>
> > l2_cache_enable:
> > - push {r0, r1, r2, lr}
> > + stmfd r13!, {r0, r1, r2, lr}
> > @ ES2 onwards we can disable/enable L2 ourselv=
> es
> > bl get_cpu_rev
> > cmp r0, #CPU_3XX_ES20
> > @@ -157,11 +157,11 @@ l2_cache_enable_EARLIER_THAN_ES2:
> > mov ip, r3
> > str r3, [sp, #4]
> > l2_cache_enable_END:
> > - pop {r1, r2, r3, pc}
> > + ldmfd r13!, {r1, r2, r3, pc}
>
> For clarity's sake, it might be worth using sp instead of r13
Agreed, but for the sake of consisitency (all other similar places in
this file use r13 as well) I decided to stick with the existing
convention.
Maybe we should submit an additional cleanp-patch that changes r13
into sp when used like this? (or always?)
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
An armed society is a polite society.
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
