On Wednesday 21 April 2010 17:40:05 Wolfgang Denk wrote: > Michael Zaidman wrote: > > > Actually there are two parts to it: > > > > > > bootcount_store() and bootcount_load() are needed for the boot > > > counter, a generic feature; I tend to move these into > > > arch/powerpc/lib/bootcount.c; the code also needs to be rewritten to > > > use I/O accessors. > > > > > > post_word_store() and post_word_load() is architecture specific, > > > common POST code that unfortunately also gets used by the logbuffer > > > code. This should be split. Then we would have > > > arch/powerpc/lib/logbuf.c and post/arch/powerpc/post_io.c or such. > > Looking at the code I wonder why we need post_word_store() and > post_word_load() functions at all. All implementations I have found > translate into a single ioread32() resp. iowrite32() call. > > > Yes, I have seen them also. I actually thought to clean up them but do > > it in two phases - first make the post_word accessors to be common per > > arch and define them as weak so it will not break existing code. > > Afterwords - eliminate an existing redundant code. > > > > Thanks for the tips. Please let me know how do you want me to proceed > > with the patch? > > I think we should perform this cleanup in the following steps: > > 1) Move bootcount_store() and bootcount_load() to architecture > specific generic locations; this includes both the PowerPC and ARM > implementations > > 2) Move arch/blackfin/lib/post.c to post/ > > 3) Eliminate post_word_store() and post_word_load() and use ioread32() > resp. iowrite32() (or equivalents) directly.
i'd love to see post/ be de-powerpc-ified and unify Blackfin stuff in there. it's been an item long standing on our side, but there's always been more pressing issues. -mike
signature.asc
Description: This is a digitally signed message part.
_______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
