Dear Michael Zaidman,
In message <o2o660c0f821004210729u4b63cd94n4cb40c87088f8...@mail.gmail.com> you
wrote:
> >
> > Actually there are two parts to it:
> >
> > bootcount_store() and bootcount_load() are needed for the boot
> > counter, a generic feature; I tend to move these into
> > arch/powerpc/lib/bootcount.c; the code also needs to be rewritten to
> > use I/O accessors.
> >
> > post_word_store() and post_word_load() is architecture specific,
> > common POST code that unfortunately also gets used by the logbuffer
> > code. This should be split. Then we would have
> > arch/powerpc/lib/logbuf.c and post/arch/powerpc/post_io.c or such.
Looking at the code I wonder why we need post_word_store() and
post_word_load() functions at all. All implementations I have found
translate into a single ioread32() resp. iowrite32() call.
> Yes, I have seen them also. I actually thought to clean up them but do
> it in two phases - first make the post_word accessors to be common per
> arch and define them as weak so it will not break existing code.
> Afterwords - eliminate an existing redundant code.
>
> Thanks for the tips. Please let me know how do you want me to proceed
> with the patch?
I think we should perform this cleanup in the following steps:
1) Move bootcount_store() and bootcount_load() to architecture
specific generic locations; this includes both the PowerPC and ARM
implementations
2) Move arch/blackfin/lib/post.c to post/
3) Eliminate post_word_store() and post_word_load() and use ioread32()
resp. iowrite32() (or equivalents) directly.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
I see that Microsoft's campaign to destroy all knowledge of any
operating environment but its own environment-of-the-year has
succeeded in creating a generation of users who don't understand the
concept of a shell...
-- L. Peter Deutsch in <m0x5jnx-000r...@lamp.aladdin.com>
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
