On 11/20/2018 02:22 PM, Sven Schwermer wrote: >>>>> This configuration doesn't use USB in the SPL, so we need to disable >>>>> driver model for USB in the SPL. >>>>> >>>>> Signed-off-by: Sven Schwermer <s...@svenschwermer.de> >>>> >>>> Is this also needed on other boards ? >>> >>> As per the cover letter, I have successfully run the Travis CI build for >>> this patch series. Furthermore, I have manually verified that all AM33xx >>> builds still succeed. So I don’t think, we need to change anything on other >>> boards. If you want me to do more testing, let me know. >> >> I just want to know whether some boards now get CONFIG_SPL_DM_USB even >> though they didn't have it before, since the Kconfig option is default=y > > Well, since CONFIG_SPL_DM_USB depends on SPL_DM_USB, I don’t think that’s the > case.
Are you _sure_ ? Sorry if I'm being hard, but this affects a lot of users, so I have to be cautious. >> btw I don't think SPL_DM_USB should depend on DM_USB , one is for SPL >> and the other for U-Boot. > > Aha! There are two reasons I did this: > 1) I used CONFIG_SPL_DM_MMC as the inspiration for my changes. That one > depends on CONFIG_DM_MMC. I don't think that's right. SPL and U-Boot are separate things. > 2) In order to not break a lot of configs, see above. > > If this is unacceptable for you, I guess, I’ll have to revisit this. That’d > make this series a lot bigger I think. Tell me your preference. I don't mind bigger and better series, but let's just answer the question first. -- Best regards, Marek Vasut _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
