On 04/05/2010 01:36 PM, Ben Warren wrote:
> Hi Thomas,
>
> On 3/19/2010 12:43 AM, Thomas Chou wrote:
>> This is a generic approach to port u-boot for nios2 boards.
>> It uses a new set of device drivers, such as the cfi flash, spi
>> lash, nand flash and new ethernet drivers.
>>
> <snip>
>> +#ifdef CONFIG_CMD_NET
>> +int board_eth_init(bd_t *bis)
>> +{
>> + int rc = 0;
>> +#ifdef CONFIG_SMC91111
>> + rc = smc91111_initialize(bis, CONFIG_SMC91111_BASE);
>> +#endif
>> +
>> +#ifdef CONFIG_DRIVER_DM9000
>> + rc = dm9000_initialize(bis);
>> +#endif
>> +
>> +#ifdef CONFIG_ALTERA_TSE
>> + altera_tse_init(bis, CONFIG_SYS_NUM_TSE_MACS);
>> +#endif
>> +
>> +#ifdef CONFIG_ETHOC
>> + rc = ethoc_initialize(bis, CONFIG_SYS_ETHOC_BASE);
>> +#endif
>> + return rc;
>> +}
> Please clean up the return code handling. The drivers are not
> mutually exclusive.
Hi Ben,
Does it make sense to return 0 always, as we don't have cpu_eth_init()?
>
> <snip>
>> +
>> +#define CONFIG_ETHADDR 08:00:3e:26:0a:5b
>> +#define CONFIG_NETMASK 255.255.255.0
>> +#define CONFIG_IPADDR 192.168.2.21
>> +#define CONFIG_SERVERIP 192.168.2.16
>> +
> Please remove these definitions
OK.
Best regards,
Thomas
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
