On 04/02/2018 05:00 AM, Philipp Tomsich wrote: > > > On Tue, 27 Mar 2018, Kever Yang wrote: > >> We add this for get the location for boot device of bootrom. > > Your commit message should be specific enough, so the motivation for > the change, where it fits into the overall architecture and what is > changed are apparent. > >> Signed-off-by: Kever Yang <kever.y...@rock-chips.com> >> Acked-by: Philipp Tomsich <philipp.toms...@theobroma-systems.com> > > See below for requested changes. > >> --- >> >> arch/arm/mach-rockchip/Kconfig | 17 +++++++++++++++++ >> 1 file changed, 17 insertions(+) >> >> diff --git a/arch/arm/mach-rockchip/Kconfig >> b/arch/arm/mach-rockchip/Kconfig >> index 5dfe452..98bf935 100644 >> --- a/arch/arm/mach-rockchip/Kconfig >> +++ b/arch/arm/mach-rockchip/Kconfig >> @@ -209,6 +209,23 @@ config ROCKCHIP_STIMER_BASE >> The secure timer inited in SPL/TPL in secure word, ARM generic >> timer >> works after this timer work. >> >> +config ROCKCHIP_IRAM_START_ADDR >> + hex "Rockchip Secure timer base address" > > Huh: copy-and-paste?
Sorry, my fault, will fix in next version. Thanks, - Kever > >> + default 0xff0e0000 if ROCKCHIP_PX30 > > See my earlier comment regarding changes specific to the PX30. > >> + default 0x10080000 if ROCKCHIP_RK3036 >> + default 0x10080000 if ROCKCHIP_RK3128 >> + default 0x10080000 if ROCKCHIP_RK3188 >> + default 0x10080000 if ROCKCHIP_RK322X >> + default 0xff700000 if ROCKCHIP_RK3288 >> + default 0xff091000 if ROCKCHIP_RK3328 >> + default 0xff8c0000 if ROCKCHIP_RK3368 >> + default 0xff8c0000 if ROCKCHIP_RK3399 >> + default 0x10080000 if ROCKCHIP_RV1108 >> + default 0 >> + help >> + The IRAM start addr is to locate variant of the boot device from >> + bootrom. > > The same comment as for the secure timer-base applies here. > This is way to important to have it in Kconfig, where a user can > easily override. > >> + >> config ROCKCHIP_SPL_RESERVE_IRAM >> hex "Size of IRAM reserved in SPL" >> default 0 >> > _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
