On 04/02/2018 04:58 AM, Philipp Tomsich wrote: > > > On Tue, 27 Mar 2018, Kever Yang wrote: > >> STIMER is can only access in secure mode if the SoCs supports trust, >> and it locate in alive power domain, as the source of ARM arch/generic >> timer, we add a base addr for all SoCs so that we can init with a common >> function. > > The commit message does not really tell what the source changes are
Then I have no idea what kind information need to add in this commit message, could you make it more clear? I can add message about there is a coming up patch to use this address. > (although it seems to describe part of the motivation for this change). > >> >> Signed-off-by: Kever Yang <kever.y...@rock-chips.com> >> Acked-by: Philipp Tomsich <philipp.toms...@theobroma-systems.com> > > See below for requested changes. > >> --- >> >> arch/arm/mach-rockchip/Kconfig | 19 +++++++++++++++++++ >> 1 file changed, 19 insertions(+) >> >> diff --git a/arch/arm/mach-rockchip/Kconfig >> b/arch/arm/mach-rockchip/Kconfig >> index 007cb22..5dfe452 100644 >> --- a/arch/arm/mach-rockchip/Kconfig >> +++ b/arch/arm/mach-rockchip/Kconfig >> @@ -190,6 +190,25 @@ config ROCKCHIP_BOOT_MODE_REG >> The Soc will enter to different boot mode(defined in >> asm/arch/boot_mode.h) >> according to the value from this register. >> >> +config ROCKCHIP_STIMER_BASE >> + hex "Rockchip Secure timer base address" >> + default 0xff220020 if ROCKCHIP_PX30 > > We don't have support for the PX30 in the U-Boot code base yet. > Until a series to add support for the PX30 comes in, you should not > have this here yet (and then add this specific case when the PX30 > support is added). > >> + default 0x200440a0 if ROCKCHIP_RK3036 >> + default 0x2000e000 if ROCKCHIP_RK3066 >> + default 0x20018020 if ROCKCHIP_RK3126 >> + default 0x200440a0 if ROCKCHIP_RK3128 >> + default 0x2000e000 if ROCKCHIP_RK3188 >> + default 0x110d0020 if ROCKCHIP_RK322X >> + default 0xff810020 if ROCKCHIP_RK3288 >> + default 0xff1d0020 if ROCKCHIP_RK3328 >> + default 0xff830020 if ROCKCHIP_RK3368 >> + default 0xff8680a0 if ROCKCHIP_RK3399 >> + default 0x10350020 if ROCKCHIP_RV1108 >> + default 0 >> + help >> + The secure timer inited in SPL/TPL in secure word, ARM generic >> timer >> + works after this timer work. > > This should not be in Kconfig and rather in a header-file. I think it's better to make this information in one place instead of in different header files(more then 10 soc header files). > With what you do here, a user (e.g. via 'make menuconfig') or a > defconfig file (e.g. due to a typo) could accidentially change > overwrite this. This value connect with the SoC type, I don't understand what kind of typo will overwrite this. Thanks, - Kever > >> + >> config ROCKCHIP_SPL_RESERVE_IRAM >> hex "Size of IRAM reserved in SPL" >> default 0 >> > _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
