[Re: [U-Boot] [PATCH 3/8] sbc8548: enable access to second bank of flash] On
23/09/2009 (Wed 22:48) Wolfgang Denk wrote:
> Dear Paul Gortmaker,
>
> In message <4aba81da.8020...@windriver.com> you wrote:
> >
> > I'd considered the line length, but there were many lines in tlb.c
> > that were already way past 80 char (see directly under the
> > comment /* TLB 0 - for temp stack in cache */ ) so I
> > decided to be consistent with existing code.
>
> I see.
>
> > If you prefer, I can create an add-on patch that re-wraps both
> > the old/existing code, and the updated line(s).
>
> It would be better to fix the existing code in an initial patch, and
> then apply an update patch.
To do this, I've rewound my copy of the 85xx repo to just before the
1st offending patch, inserted the cosmetic line wrap patch, and then
re-applied all the remaining 85xx updates that I was responsible for.
The patches are all unchanged, with the exception of re-wrapping any
long lines in tlb.c -- which impacted the patches marked with a "*"
I hope this what you had in mind. If not, or if you want patches
in e-mail then let me know.
Thanks,
Paul.
---
The following changes since commit
80f0cc6009a7bfdbb1458fcd50c4592badd33f83:
Paul Gortmaker (1):
sbc8548: get_clock_freq is not valid for this board
are available in the git repository at:
git://openlinux.windriver.com/people/paulg/u-boot wd-sbc8548
Paul Gortmaker (9):
sbc8548: cosmetic line re-wrap
* sbc8548: enable access to second bank of flash
sbc8548: remove eTSEC3/4 voltage hack
sbc8548: use I/O accessors
* sbc8548: correct local bus SDRAM size from 64M to 128M
fsl_pci: create a SET_STD_PCI_INFO() helper wrapper
* sbc8548: update PCI/PCI-e support code
sbc8548: allow enabling PCI via a make config option
sbc85x0: tidy up Makefile to use new configuration script.
MAKEALL | 4 +
Makefile | 26 ++----
board/sbc8548/law.c | 12 ++-
board/sbc8548/sbc8548.c | 234 +++++++++++++++++---------------------------
board/sbc8548/tlb.c | 80 ++++++++++-----
include/asm-ppc/fsl_pci.h | 12 +++
include/configs/SBC8540.h | 19 ++--
include/configs/sbc8548.h | 137 +++++++++++++++++++-------
include/configs/sbc8560.h | 17 +++-
9 files changed, 300 insertions(+), 241 deletions(-)
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
