> -----Original Message----- > From: Simon Kagstrom [mailto:simon.kagst...@netinsight.net] > Sent: Friday, September 11, 2009 7:22 PM > To: Prafulla Wadaskar > Cc: U-Boot ML; Dhaval Vasa; Prabhanjan Sarnaik; Ashish > Karkare; Ben Warren > Subject: Re: [PATCH v2] Support for the OpenRD base board > > On Fri, 11 Sep 2009 06:33:44 -0700 > Prafulla Wadaskar <prafu...@marvell.com> wrote: > > > > > > +#define CONFIG_ENV_SIZE 0x20000 > /* 128k */ > > > > > +#define CONFIG_ENV_ADDR 0xa0000 > > > > > +#define CONFIG_ENV_OFFSET 0xa0000 /* env > > > starts here */ > > > > Do you really need this address? the u-boot binary is > > > within 256kb, at the most it can go till 512kb > > > > > > This is where the default environment (for the U-boot shipped by > > > Marvell) resides. Like on Sheevaplug, it uses 4-bit ECC, > so current > > > U-boot won't be able to read it, but I know you're working on it. > > So I think, you want to retain both environment variables untouched > > ( i.e. latest u-boot and u-boot shipped by Marvell) > > But so far as mainlined u-boot is considered, > > doesn't it make sense to pack uboot-bin and environment > sector together? > > like sheevaplug, I think first 2 sectors for u-boot and > next once sector for env should be better to choose. > > Right, makes sense. I'll update that and skip the current address. > > > > > > +#define MTDIDS_DEFAULT "nand0=nand_mtd" > > > > > +#define MTDPARTS_DEFAULT > > > > > "mtdparts=nand_mtd:0x100...@0x000000(uboot),0x400...@0x100000( > > > > > uImage),"\ > > > > > + "0x1fb00...@0x500000(rootfs)" > > > > > I don't quite understand this. This is also the default addresses > > > shipped with the board. > > > W..r.to line 24 at > http://git.marvell.com/?p=orion.git;a=blob;f=arch/arm/mach-kir > kwood/openrd_base-setup.c;h=947dfb8cd5b252bf326d691ee5179e29ad > 07a9a9;hb=HEAD > > By default kernel has same mdtpart configuration as you are > describing here. > > So you don't need this default setup here, you should skip it > > OK, I understand. However, but it might also be useful from U-boot. > Locally, I've loaded the kernel from the ubifs partition, and > then it's > useful to have this defined in U-boot as well. If it > shouldn't be there > by default, I'll remove it though. Yes. I leave decision up to you for this. My intension was to save some thing which is not required
Regards.. Prafulla. . . > > // Simon > _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
