Dear Wolfgang 2009/9/10 Wolfgang Denk <[email protected]>: > Dear Minkyu Kang, > > In message <[email protected]> you wrote: >> Add new board SMDKC100 that uses s5pc100 SoC >> >> Signed-off-by: Minkyu Kang <[email protected]> >> Signed-off-by: HeungJun, Kim <[email protected]> > ... >> +#ifndef __CONFIG_H >> +#define __CONFIG_H >> +#include <asm/sizes.h> > > Please don't use this header; it will probably be removed soon. >
ok, I'll also remove SZ_XX defines > ... >> +/* >> + * Architecture magic and machine type >> + */ >> +#define MACH_TYPE_SMDKC100 1826 > > Please don't. Only use the constants defined in mach-types.h > it will be deleted > ... >> +/*----------------------------------------------------------------------- >> + * Boot configuration (define only one of next 3) >> + */ >> +#define CONFIG_ENV_IS_IN_ONENAND 1 >> +#define CONFIG_ENV_SIZE SZ_128K /* 128KB, >> 0x20000 */ >> +#define CONFIG_ENV_ADDR SZ_256K /* 256KB, >> 0x40000 */ >> +#define CONFIG_ENV_OFFSET SZ_256K /* 256KB, 0x40000 */ > > What does the "define only one of next 3" part mean? > ah.. SMDKC100 can boot by onenand, nand and flash. that means.. must define one of three.. anyway it will be deleted. > > Best regards, > > Wolfgang Denk > > -- > DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel > HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany > Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [email protected] > "Though a program be but three lines long, > someday it will have to be maintained." > - The Tao of Programming > _______________________________________________ > U-Boot mailing list > [email protected] > http://lists.denx.de/mailman/listinfo/u-boot > thanks -- from. prom. www.promsoft.net _______________________________________________ U-Boot mailing list [email protected] http://lists.denx.de/mailman/listinfo/u-boot
