Kyungmin Park wrote: > On Wed, Sep 23, 2009 at 9:05 PM, Tom <tom....@windriver.com> wrote: >> Minkyu Kang wrote: >>> Dear Tom >>> >>> 2009/9/23 Tom <tom....@windriver.com>: >>>> Minkyu Kang wrote: >>>>> Adds new board SMDKC100 that uses s5pc100 SoC >>>>> >>>>> Signed-off-by: Minkyu Kang <mk7.k...@samsung.com> >>>>> Signed-off-by: HeungJun, Kim <riverful....@samsung.com> >>>>> --- >> <snip> >> >>>>> +#ifndef CONFIG_ONENAND_IPL >>>>> + /* setting SRAM */ >>>>> + ldr r0, =S5PC100_SROMC_BASE >>>>> + ldr r1, =0x9 >>>>> + str r1, [r0] >>>>> +#endif >>>> Where is CONFIG_ONENAND_IPL defined ? >>>> If it is not being used, the #ifndef logic should be reduced. >>> Kyungmin Park sent the patch that is supported onenand_ipl for s5pc1xx. >>> but not yet applied onenand_ipl patch for s5pc1xx. >>> When that patch is applied, we need these logic. >>> If necessary, I'll delete these logic until apply the patch. >>> >> If the patch already exits, it would be better if it was in this >> patchset. Can we get the onenand_ipl patch ? > > To support the s5pc1xx OneNAND IPL. It needs to refactor the current > OneNAND IPL. > > Now I refactor the OneNAND IPL code first and then I will send a > OneNAND IPL codes for s5pc1xx. > > I want to leave current patch as is. Since If we delete the OneNAND > IPL codes. No one can refer the codes. I mean OneNAND IPL parts > contains clock and memory configuration. These are helpful to someone > who use NAND or NOR. >
Yes. Leaving this patch as-is is Ok. Please refactor the old patch and include it as this patch's dependant in the next revision of s5pc1xx patch set. Tom > Thank you, > Kyungmin Park _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
