Dear Minkyu Kang, In message <4aa8ac52.4010...@samsung.com> you wrote: > Add new board SMDKC100 that uses s5pc100 SoC > > Signed-off-by: Minkyu Kang <mk7.k...@samsung.com> > Signed-off-by: HeungJun, Kim <riverful....@samsung.com> ... > +#ifndef __CONFIG_H > +#define __CONFIG_H > +#include <asm/sizes.h>
Please don't use this header; it will probably be removed soon. ... > +/* > + * Architecture magic and machine type > + */ > +#define MACH_TYPE_SMDKC100 1826 Please don't. Only use the constants defined in mach-types.h ... > +/*----------------------------------------------------------------------- > + * Boot configuration (define only one of next 3) > + */ > +#define CONFIG_ENV_IS_IN_ONENAND 1 > +#define CONFIG_ENV_SIZE SZ_128K /* 128KB, > 0x20000 */ > +#define CONFIG_ENV_ADDR SZ_256K /* 256KB, > 0x40000 */ > +#define CONFIG_ENV_OFFSET SZ_256K /* 256KB, 0x40000 */ What does the "define only one of next 3" part mean? Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de "Though a program be but three lines long, someday it will have to be maintained." - The Tao of Programming _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
