Dear Thomas Petazzoni,

In message <20090715163557.08b58...@surf> you wrote:
> Support for the Calao USB A9263 board
>  
> The Calao USB A9263 board is a board manufactured and sold by Calao
> Systems <http://www.calao-systems.com>. Its components are very
> similar to the AT91SAM9263EK board, so its configuration is based on
> the configuration of this board. There are however some differences:
> different clocks, no LCD, etc.
>  
> Signed-off-by: Thomas Petazzoni <thomas.petazz...@free-electrons.com>
> 
> ---
...
>  MAKEALL                           |    1 
>  Makefile                          |    3 
>  board/calao/usb-a9263/Makefile    |   56 ++++++++
>  board/calao/usb-a9263/config.mk   |    1 
>  board/calao/usb-a9263/led.c       |   44 ++++++
>  board/calao/usb-a9263/partition.c |   37 +++++
>  board/calao/usb-a9263/usb-a9263.c |  193 ++++++++++++++++++++++++++++
>  include/configs/usb-a9263.h       |  186 ++++++++++++++++++++++++++
>  8 files changed, 521 insertions(+)

Entries to maintainers is missing.

> +int dram_init(void)
> +{
> +     gd->bd->bi_dram[0].start = PHYS_SDRAM;
> +     gd->bd->bi_dram[0].size = PHYS_SDRAM_SIZE;
> +     return 0;
> +}

Any specific reason for not using autosizing and testing via
get_ram_size() ?

> diff --git a/include/configs/usb-a9263.h b/include/configs/usb-a9263.h
> new file mode 100644
> index 0000000..b670f5f
> --- /dev/null
> +++ b/include/configs/usb-a9263.h
...
> +/* bootstrap + u-boot + env in dataflash on CS0 */
> +#define CONFIG_ENV_IS_IN_DATAFLASH   1
> +#define CONFIG_SYS_MONITOR_BASE      (CONFIG_SYS_DATAFLASH_LOGIC_ADDR_CS0)
> +#define CONFIG_ENV_OFFSET            0x2000
> +#define CONFIG_ENV_ADDR              (CONFIG_SYS_DATAFLASH_LOGIC_ADDR_CS0 + 
> CONFIG_ENV_OFFSET)

Line too long. Please fix globally.


Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
[Doctors and Bartenders], We both get the same two kinds of customers
-- the living and the dying.
        -- Dr. Boyce, "The Menagerie" ("The Cage"), stardate unknown
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Reply via email to