On Wed, 2009-07-15 at 16:35 +0200, Thomas Petazzoni wrote: > Support for the Calao USB A9263 board
You can get rid of the line above. It is nearly identical to the patch subject and doesn't add any useful info. <snip> > > MAKEALL | 1 > Makefile | 3 You should add an entry to MAINTAINERS <snip> > +/* LED */ > +#define CONFIG_AT91_LED > +#define CONFIG_RED_LED AT91_PIN_PB7 /* this is the power > led */ > +#define CONFIG_GREEN_LED AT91_PIN_PB8 /* this is the user1 > led */ > +#define CONFIG_YELLOW_LED AT91_PIN_PC29 /* this is the user2 > led */ Funky indentation. <snip> > +#define ROUND(A, B) (((A) + (B)) & ~((B) - 1)) I'd try and use the round functions already in include/common.h if possible. Maybe its not possible if this file is included prior to common.h though, I'm not sure. Best, Peter _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
