On 18 June 2015 at 07:50, Wang Haikun <haikun.w...@freescale.com> wrote: > On 6/17/2015 8:30 PM, Simon Glass wrote: >> Hi, >> >> On 17 June 2015 at 03:36, Bin Meng <bmeng...@gmail.com> wrote: >>> Hi Haikun, >>> >>> On Mon, May 18, 2015 at 9:25 PM, Haikun Wang <haikun.w...@freescale.com> >>> wrote: >>>> From: Haikun Wang <haikun.w...@freescale.com> >>>> >>>> Enable Driver Model SPI for ls1021atwr board. >>>> DSPI and QSPI only be enabled when boot from QSPI. >>>> DSPI and QSPI are compatible under Driver Model SPI. >>>> >>>> Signed-off-by: Haikun Wang <haikun.w...@freescale.com> >>>> Change-Id: I6342807da7725ae8b678952117c8758c75a61d3d >>>> Reviewed-on: http://git.am.freescale.net:8181/33447> > Best regards, > Wang Haikun >> >>> >>> Is this URL Freescale internal? I cannot access it. >>> >> >> Looks like it. BTW patman will remove these Gerrit tags automatically. > Yes, it is our internal URL. > I forget to remove it. > It couldn't be better if it will be removed automatically.
I will remove if something not remove automatically. Anyone have any comments on these patch-set, I'm planning to take these. https://patchwork.ozlabs.org/patch/473391/ https://patchwork.ozlabs.org/patch/473392/ https://patchwork.ozlabs.org/patch/473393/ https://patchwork.ozlabs.org/patch/473394/ >>>> Tested-by: Review Code-CDREVIEW <cdrev...@freescale.com> >>>> Reviewed-by: Prabhakar Kushwaha <prabha...@freescale.com> >>>> --- >>>> Changes in v3: >>>> - IS_ENABLED(CONFIG_XXX) is only work with configure option in Kconfig, >>>> and DM core code use IS_ENABLED(), so configure option in head file >>>> can't work, so remove CONFIG_OF_CONTROL CONFIG_OF_SEPARATE CONFIG_DM >>>> CONFIG_DM_SPI >>>> >>>> Changes in v2: >>>> - Move all changes inside of CONFIG_QSPI_BOOT >>>> >>>> Changes in v1: None >>>> include/configs/ls1021atwr.h | 10 ++++++++-- >>>> 1 file changed, 8 insertions(+), 2 deletions(-) >>>> >>>> diff --git a/include/configs/ls1021atwr.h b/include/configs/ls1021atwr.h >>>> index 729205f..13e3aa4 100644 >>>> --- a/include/configs/ls1021atwr.h >>>> +++ b/include/configs/ls1021atwr.h >>>> @@ -229,16 +229,22 @@ >>>> #define CONFIG_CMD_FAT >>>> #define CONFIG_DOS_PARTITION >>>> >>>> -/* QSPI */ >>>> +/* SPI */ >>>> #ifdef CONFIG_QSPI_BOOT >>>> +/* QSPI */ >>>> #define CONFIG_FSL_QSPI >>>> #define QSPI0_AMBA_BASE 0x40000000 >>>> #define FSL_QSPI_FLASH_SIZE (1 << 24) >>>> #define FSL_QSPI_FLASH_NUM 2 >>>> >>>> +#define CONFIG_SPI_FLASH_STMICRO >>>> + >>>> +/* DM SPI */ >>>> +#if defined(CONFIG_FSL_DSPI) || defined(CONFIG_FSL_QSPI) >>>> #define CONFIG_CMD_SF >>>> +#define CONFIG_DM_SPI_FLASH >>>> #define CONFIG_SPI_FLASH >>>> -#define CONFIG_SPI_FLASH_STMICRO >>>> +#endif >>>> #endif >>>> >>>> /* >>>> -- thanks! -- Jagan | openedev. _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
