On 26 June 2015 at 08:43, Wang Haikun <haikun.w...@freescale.com> wrote: > On 6/25/2015 9:24 PM, Jagan Teki wrote: >> On 19 June 2015 at 13:44, Jagan Teki <jt...@openedev.com> wrote: >>> On 19 June 2015 at 13:20, Wang Haikun <haikun.w...@freescale.com> wrote: >>>> On 6/19/2015 3:34 PM, Jagan Teki wrote: >>>>> On 18 June 2015 at 12:24, Jagan Teki <jt...@openedev.com> wrote: >>>>>> On 18 June 2015 at 07:50, Wang Haikun <haikun.w...@freescale.com> wrote: >>>>>>> On 6/17/2015 8:30 PM, Simon Glass wrote: >>>>>>>> Hi, >>>>>>>> >>>>>>>> On 17 June 2015 at 03:36, Bin Meng <bmeng...@gmail.com> wrote: >>>>>>>>> Hi Haikun, >>>>>>>>> >>>>>>>>> On Mon, May 18, 2015 at 9:25 PM, Haikun Wang >>>>>>>>> <haikun.w...@freescale.com> wrote: >>>>>>>>>> From: Haikun Wang <haikun.w...@freescale.com> >>>>>>>>>> >>>>>>>>>> Enable Driver Model SPI for ls1021atwr board. >>>>>>>>>> DSPI and QSPI only be enabled when boot from QSPI. >>>>>>>>>> DSPI and QSPI are compatible under Driver Model SPI. >>>>>>>>>> >>>>>>>>>> Signed-off-by: Haikun Wang <haikun.w...@freescale.com> >>>>>>>>>> Change-Id: I6342807da7725ae8b678952117c8758c75a61d3d >>>>> >>>>> Where is this commit id? I couldn't see it on "git log" >>>> Hi Jagan, >>>> >>>> It is not a git commit ID, it is a code review task ID of gerrit in fact. >>>> I'm sorry again for forgetting remove it when submit patch. >>>> >>>> Best regards, >>>> Wang Haikun >>>>> >>>>>>>>>> Reviewed-on: http://git.am.freescale.net:8181/33447> >>>>>>> Best regards, >>>>>>> Wang Haikun >>>>>>>> >>>>>>>>> >>>>>>>>> Is this URL Freescale internal? I cannot access it. >>>>>>>>> >>>>>>>> >>>>>>>> Looks like it. BTW patman will remove these Gerrit tags automatically. >>>>>>> Yes, it is our internal URL. >>>>>>> I forget to remove it. >>>>>>> It couldn't be better if it will be removed automatically. >>>>>> >>>>>> I will remove if something not remove automatically. >>>>>> >>>>>> Anyone have any comments on these patch-set, I'm planning to take these. >>>>>> >>>>>> https://patchwork.ozlabs.org/patch/473391/ >>>>>> https://patchwork.ozlabs.org/patch/473392/ >> >>>>>> https://patchwork.ozlabs.org/patch/473393/ >>>>>> https://patchwork.ozlabs.org/patch/473394/ >> Few CONFIG_DM_* were missing in these two patches, did these patches >> have any dependencies with other series, please look at and let me know. > > I found that macro IS_ENABLED(CONFIG_XXX) is only work with configure > option in Kconfig, and DM core code use IS_ENABLED(), so configure > option in head file can't work, so remove CONFIG_OF_CONTROL > CONFIG_OF_SEPARATE CONFIG_DM CONFIG_DM_SPI in the head file.
Please send the patch for this fix, found build errors by picking these patches. thanks! -- Jagan | openedev. _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
