On Sun, Mar 22, 2009 at 10:21 AM, Wolfgang Denk <w...@denx.de> wrote: > Dear Jon, > > In message <9e4733910903220701h104932cdu6b226e5c05e9b...@mail.gmail.com> you > wrote: >> >> I've test this version with the eeprom and it works correctly. > > It may work, but such a macro definition violates some rules. > >> +#define printf(format, arg...) if (gd->have_console) printf(format, ## arg) > > There are only a few places in cpu/mpc5xxx/i2c.c where printf() is > used that we should explicitly code this, there.
Would it be better to put the check for (gd->have_console) into printf itself? -- Jon Smirl jonsm...@gmail.com _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
