Dear Jon Smirl, In message <9e4733910903221955h4a6b3c24t34cce6989911b...@mail.gmail.com> you wrote: > On Sun, Mar 22, 2009 at 11:23 AM, Wolfgang Denk <w...@denx.de> wrote: > > Dear Jon Smirl, > > > > In message <9e4733910903220723u31546286q233c9b24b7a5...@mail.gmail.com> y= > ou wrote: > >> > >> Would it be better to put the check for (gd->have_console) =A0into print= > f itself? > > > > No, as you could also use puts() or putc(). =A0There =A0are =A0only =A0a = > =A0few > > isolated =A0places =A0where =A0we =A0need =A0this, =A0so =A0let's make th= > is clearly > > visible there. > > mpc5200 with eeprom, suppress printf until console initialized > > From: Jon Smirl <jonsm...@gmail.com>
Argh.... Such comments have to go *below* the '---' line, otherwise they become part of the commit message. And your patch is line-wrapped and thus corrupted by your mailer. Please FIX your mailer (or even better use git-send-email to submit patches). > On boards which have the environment in eeprom, i2c_init() > is called before the console and ram is initialized. Suppress > printfs until the console is initialized. > > Signed-off-by: Jon Smirl <jonsm...@gmail.com> > --- > cpu/mpc5xxx/i2c.c | 30 ++++++++++++++++++++---------- > 1 files changed, 20 insertions(+), 10 deletions(-) Fixed manually and applied. Thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de "In Christianity neither morality nor religion come into contact with reality at any point." - Friedrich Nietzsche _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
