Dear kenneth johansson,
In message <1230715433.19628.12.ca...@duo> you wrote:
>
> > If you find the make output annoying, you can silence make by passing
> > the "-s" flag.
>
> -s is a bit to much you get no feedback at all.
But that's the preferred way of doing things, at least according to
Unix Philosophy.
No news is good news. Running a "./MAKEALL <boardname>" on a somewhat
decent machine takes no more than 10...20 seconds. Either you get
warnings / error messages, or not. What else is needed?
> > On the other hand, your patch braks building with "-s" - I get:
>
> oops that was not intended.
>
> > Even without "-s" there are some errors for example when I try to
> > build the "TQM5200" configuration.
>
> with errors I guess you mean non optimal output. the patch really should
No, with errors I mean things like "grep: writing output: Broken pipe".
> > Unless you have a really good reason why this patch should be
> > applied, I tend to reject it.
>
> No it's only a way to remove most of the noise as mentioned it has no
> effect on u-boot itself.
If you want to have a silent build (which I do almost always, too),
then either use "./MAKEALL <boardname>" or "make -s".
> while it's a large patch it's mostly trivial search/replace so it's easy
> to remove should people object to it.
I diasgree. The changes are far from trivial.
> here is a small addition to the patch fixing the issues with -s you
> found.
I think your appraoch (and that of kbuild, too) is fundamentally
broken. Fixing this on the Makefile level is at least one level to
far up. If you really want a verbosity level of make that is between
no options (normal case) and no output (except warnings/errors, as
with -s), then this should be implemnted within make itself, as a new
make option.Then you have the changes in one place only, and each and
every software package can benefit from it. Modifying hundrets of
Makefiles here and there and then again for each new software package
makes absolutely no sense to me.
U-Boot is the wrong place to fix this. Please fix this in make, for
the benefit of others, too.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
Substitute "damn" every time you're inclined to write "very"; your
editor will delete it and the writing will be just as it should be.
- Mark Twain
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
