On Tue, 2008-12-30 at 23:14 +0100, Wolfgang Denk wrote:
> Dear kenneth johansson,
>
> In message <1230636057.17914.5.ca...@duo> you wrote:
> >
> > Only print out the target name during make.
> > For old style set V=1
>
> What is the rationale for this patch? I can see no real advantage with
> it.
To highlight warnings during build. It's just a way to make the default
output less noise.
>
> If you find the make output annoying, you can silence make by passing
> the "-s" flag.
-s is a bit to much you get no feedback at all.
>
> On the other hand, your patch braks building with "-s" - I get:
oops that was not intended.
> Even without "-s" there are some errors for example when I try to
> build the "TQM5200" configuration.
with errors I guess you mean non optimal output. the patch really should
not have any impact on the binaries built. If it really breaks the build
that is a real problem and one I do not see in my test.
> Unless you have a really good reason why this patch should be
> applied, I tend to reject it.
No it's only a way to remove most of the noise as mentioned it has no
effect on u-boot itself.
while it's a large patch it's mostly trivial search/replace so it's easy
to remove should people object to it.
But please try it out for a while and see what people think. My guess is
that the amount of warnings showing up during build will be reduced over
time with this type of feedback during build.
here is a small addition to the patch fixing the issues with -s you
found.
---------------------------
diff --git a/board/tqc/tqm5200/Makefile b/board/tqc/tqm5200/Makefile
index de0934b..b233e93 100644
--- a/board/tqc/tqm5200/Makefile
+++ b/board/tqc/tqm5200/Makefile
@@ -41,7 +41,7 @@ distclean: clean
rm -f $(LIB) core *.bak $(obj).depend
cam5200_flash.o: cam5200_flash.c
- $(CC) $(CFLAGS) -fno-strict-aliasing -c -o $@ $<
+ $(QUIET_CC)$(CC) $(CFLAGS) -fno-strict-aliasing -c -o $@ $<
#########################################################################
diff --git a/config.mk b/config.mk
index 51a08e4..bab6ebb 100644
--- a/config.mk
+++ b/config.mk
@@ -214,10 +214,13 @@ ifndef V
ARFLAGS = cr
export V
-endif
-else #($(findstring $(MAKEFLAGS),s),s)
-ARFLAGS = crv
-endif
+else
+ ARFLAGS = crv
+endif # V
+
+else
+ ARFLAGS = cr
+endif # ($(findstring $(MAKEFLAGS),s),s)
ifndef REMOTE_BUILD
diff --git a/post/Makefile b/post/Makefile
index 74a0672..a7085ef 100644
--- a/post/Makefile
+++ b/post/Makefile
@@ -58,7 +58,7 @@ $(GPLIB): $(obj).depend $(OBJS)
# specific POST libraries
$(SPLIB): $(obj).depend postdeps
- $(MAKE) -C $(dir $(subst $(obj),,$@))
+ @$(MAKE) -C $(dir $(subst $(obj),,$@))
# the POST lib archive
$(LIB): $(GPLIB) $(SPLIB)
diff --git a/post/rules.mk b/post/rules.mk
index 1efc9c7..5fcb2d2 100644
--- a/post/rules.mk
+++ b/post/rules.mk
@@ -34,7 +34,7 @@ CPPFLAGS += -I$(TOPDIR)
all: $(LIB)
$(LIB): $(obj).depend $(OBJS)
- $(AR) $(ARFLAGS) $@ $(OBJS)
+ $(QUIET_AR)$(AR) $(ARFLAGS) $@ $(OBJS)
#########################################################################
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
