Hello All, > NAK, and NAK again from me. Note that it's not only a single small > violation, there is a whole list of it evenin this short code snippet: > - incorrect brace style > - unnecessary indentation > - incorrect multi-line comment style
Okay, I used Linux/checkpatch.pl to check the coding style. It did not complain at all, so are we in U-boot more pedantic than the pedantic linix/checkpatch.pl script? But, to keep everybody happy, I will change that and post a new patch soon... Remy > > It is much easier to fix such code when it's being added, than to fix > it later (which may or may not happen). See all the examples that got > commited that way - and that haven't been fixed since. > > Best regards, > > Wolfgang Denk > > -- > DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel > HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany > Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [EMAIL PROTECTED] > Experience is what causes a person to make new mistakes instead of > old ones. > _______________________________________________ > U-Boot mailing list > U-Boot@lists.denx.de > http://lists.denx.de/mailman/listinfo/u-boot > _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
