On Thu, Oct 09, 2008 at 08:45:21PM +0200, Wolfgang Denk wrote:
> In message <[EMAIL PROTECTED]> you wrote:
> >
> > > > >
> > > > > > - else
> > > > > > + else {
> > > > > > + /* Let's wait a while for the timeout to elaps.
> > > > > > + * it has no real use, but it keeps the interface
> > > > > > happy. */
> > > > > > + wait_ms(timeout);
> > > > > > return -1;
> > > > > > + }
> > > >
> > > > Good catch.
> > >
> > > Quite honest, I think this is *way* to pedantic. I'd really prefer to
> > > let people who are contributing significantly do their work instead of
> > > bugging them with such rare coding style violations.
> >
> > ACK from me here. "Minor" coding style violations like these braces issue
> > or
> > too long lines should not delay patches.
>
> NAK, and NAK again from me. Note that it's not only a single small
> violation, there is a whole list of it evenin this short code snippet:
> - incorrect brace style
> - unnecessary indentation
> - incorrect multi-line comment style
>
> It is much easier to fix such code when it's being added, than to fix
> it later (which may or may not happen). See all the examples that got
> commited that way - and that haven't been fixed since.
True, you're technically right, of course, and I don't question
enforcing coding style in general. I just think that being too
critical has the potential of putting people off, and IMHO this list
can be very critical. Sometimes it's better to get a patch with a
couple of coding style violations than keeping the bug it would have
fixed.
Best regards
Markus
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: [EMAIL PROTECTED]")
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
