On Thu, Oct 09, 2008 at 03:19:22PM +0200, Wolfgang Denk wrote:
> Dear Jean-Christophe PLAGNIOL-VILLARD,
>
> In message <[EMAIL PROTECTED]> you wrote:
> >
> > > if (dev->status == 0)
> > > return dev->act_len;
> > please add {} to if too or remove the else
> > > - else
> > > + else {
> > > + /* Let's wait a while for the timeout to elaps.
> > > + * it has no real use, but it keeps the interface happy. */
> > > + wait_ms(timeout);
> > > return -1;
> > > + }
>
> Good catch.
Quite honest, I think this is *way* to pedantic. I'd really prefer to
let people who are contributing significantly do their work instead of
bugging them with such rare coding style violations.
> Actually the "else" should be removed.
How so?
Best regards
Markus
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: [EMAIL PROTECTED]")
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
