On Freitag, 28. Juni 2013 15:06:41 CEST, Jan Kundrát wrote:
On Friday, 28 June 2013 14:31:21 CEST, Thomas Lübking wrote:
The point about a common class is to allow generic job handlers as well as not to have to write the same stupid "stop", "cancelled", "finished" interface multiple times.

Speaking about the KJob, I'd prefer to keep the interface small and not export stuff like uiDelegate(), percent(), speed() etc which make little sense in this particular context.
I didn't mean to have an extensive API but just the fact that there's a common 
Job class derived by all others.

Do you have any specific example of what would be easier if the password and abook jobs shared a common ancestor?
Error logging or similar can connect a generic "Job::error(int id, QString 
desc)" slot and you don't have to define the signals, resp. members/getters lilke 
m_/id() multiple times.

Cheers,
Thomas

Reply via email to