On Monday, 8 July 2013 16:05:28 CEST, Kevin Krammer wrote:
- AbookAddressbook has lots of public API that is not in
AddressbookInterface (e.g. model).
It is needed in AddressbookInterface (somewhere for Trojita)? Or
where is problem? AbookAddressbook is also used by be.contacts
standalone application, so that methods must be public for access
outside class.
It might be better to separate this into two classes.
One that implements the addressbook and one that implements the interface
using an instance of that class.
One reason is that anyone creating new plugins will look at the existing
plugins and it would be better to clearly show which parts are
the plugin and
which are the code dealing with the actual data access behind the scenes.
But it would be good to get the opinion of the ABook code
creator/maintainer
on this first.
This one is for Thomas. From my side, splitting them in any way which makes
sense is OK as long as it doesn't complicate the code too much (and now I
see that it probably explains what I asked about in my review, I guess).
The comment about the existing plugins being used as a baseline is a valid
one.
Cheers,
Jan
--
Trojitá, a fast Qt IMAP e-mail client -- http://trojita.flaska.net/
