On Wednesday 26 June 2013 19:38:03 Jan Kundrát wrote: > On Friday, 21 June 2013 22:36:48 CEST, Pali Rohár wrote: > > virtual qint64 features() const = 0; > > I am no expert on this part of the language, but wouldn't a > quint64 make more sense here? Presumably, one wants to use it > like this: > > if (plugin->features() & AddressbookInterface::ReadOnly) ... > > Which leads to an interesting problem, unless I'm wrong -- > what is the size of the AddressbookInterface::ReadOnly, and > does it really mask-out any bits but the LSB one? > > Do we really have to mess with C-style features here? Could we > use something reasonable like QFlags and Q_DECLARE_FLAGS? > Does it provide what we need (especially the constant size of > the return value)? > > Apart from that (and the style issues I raised in the review > of the password plugin interface, and a missing license > header which shall be put there when you commit your stuff > into git), this looks good -- thanks! > > Cheers, > Jan
Ok, I changed qint64 to QFlags. And I merged factory class from password and addressbook interfaces to one, because both have same functions. It is easier to match correct trojita plugin in trojita plugin loader. Here is git repository (branch master) with my gsoc code: http://quickgit.kde.org/?p=clones/trojita/pali/trojita.git I'm not going to push interfaces to trojita master until plugins will be available, because there could be problem with interface. -- Pali Rohár pali.ro...@gmail.com
signature.asc
Description: This is a digitally signed message part.
