On Fri, 26 Jun 2026 10:58:15 GMT, Thomas Schatzl <[email protected]> wrote:
>> Ivan Walulya has updated the pull request incrementally with one additional >> commit since the last revision: >> >> StefanK review > > src/hotspot/share/gc/g1/g1HeapRegionSet.cpp line 300: > >> 298: assert(num_regions() + num_regions_to_remove == old_length, >> 299: "[%s] new length should be consistent " >> 300: "new length: %u old length: %u num_regions: %u", > > length -> old_num_regions etc.? left length naming for the explicit list `G1FreeRegionList`. > src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/tools/HeapSummary.java > line 253: > >> 251: G1HeapRegionSetBase oldSet = g1h.oldSet(); >> 252: G1HeapRegionSetBase humongousSet = g1h.humongousSet(); >> 253: long oldGenRegionNum = oldSet.numRegions() + >> humongousSet.numRegions(); > > Maybe these locals ending in `Num` could be fixed up as well. Will do as a follow up, it triggers cleans up in G1MonitoringSupport.java. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/31688#discussion_r3481089782 PR Review Comment: https://git.openjdk.org/jdk/pull/31688#discussion_r3481094212
