On Fri, 22 May 2026 04:48:59 GMT, Serguei Spitsyn <[email protected]> wrote:
>> src/hotspot/share/prims/jvmtiEventController.cpp line 105: >> >>> 103: static const jlong EXCEPTION_BITS = EXCEPTION_THROW_BIT | >>> EXCEPTION_CATCH_BIT; >>> 104: static const jlong INTERP_EVENT_BITS = SINGLE_STEP_BIT | >>> METHOD_ENTRY_BIT | METHOD_EXIT_BIT | >>> 105: FRAME_POP_BIT | FIELD_ACCESS_BIT | >>> FIELD_MODIFICATION_BIT; >> >> I see `can_generate_frame_pop_events` is still used when setting >> `JvmtiExport::_can_post_interpreter_events` in >> `JvmtiManageCapabilities::update()`. Should we fix that? In that case the >> check in `InterpreterMacroAssembler::notify_method_exit` should be >> `JvmtiExport::can_post_interpreter_events()` || >> `JvmtiExport::can_post_frame_pop`. > > Thank you for the suggestion. I was also thinking about this kind of > inconsistency but considered such a change a little bit risky and intrusive. > Let me give it a try. I'll let you know about the progress. Update: Implemented and pushed the suggestion above to decouple `JvmtiExport::can_post_frame_pop()` from `JvmtiExport::can_post_interpreter_events()`. Mach5 tiers 1-6 look clean. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/28407#discussion_r3287468838
