On Thu, 21 May 2026 16:37:38 GMT, Patricio Chilano Mateo
<[email protected]> wrote:
>> Serguei Spitsyn has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> remove trailing spaces from one file
>
> src/hotspot/cpu/x86/interp_masm_x86.cpp line 1621:
>
>> 1619:
>> 1620: movl(rdx, Address(rdx, JvmtiThreadState::frame_pop_cnt_offset()));
>> 1621: movl(rcx, Address(rthread,
>> JavaThread::interp_only_mode_offset())); // can we use rcx too?
>
> Comment can be removed.
Thanks. Removed now.
> src/hotspot/share/prims/jvmtiThreadState.hpp line 252:
>
>> 250: void incr_frame_pop_cnt() {
>> 251: assert(Threads::number_of_threads() == 0 ||
>> JvmtiThreadState_lock->is_locked(), "sanity check");
>> 252: AtomicAccess::inc(&_frame_pop_cnt);
>
> How about adding: `assert(_frame_pop_cnt > 0, "Unexpected count: %d",
> _frame_pop_cnt);`
Thanks. Added now.
> src/hotspot/share/prims/jvmtiThreadState.hpp line 257:
>
>> 255: void decr_frame_pop_cnt() {
>> 256: assert(Threads::number_of_threads() == 0 ||
>> JvmtiThreadState_lock->is_locked(), "sanity check");
>> 257: AtomicAccess::dec(&_frame_pop_cnt);
>
> How about adding: `assert(_frame_pop_cnt >= 0, "Unexpected count: %d",
> _frame_pop_cnt);`
> Also for `decr_frame_pop_cnt` below.
Thanks. Added now.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/28407#discussion_r3285713707
PR Review Comment: https://git.openjdk.org/jdk/pull/28407#discussion_r3285719953
PR Review Comment: https://git.openjdk.org/jdk/pull/28407#discussion_r3285720380
