On Thu, 21 May 2026 16:49:10 GMT, Patricio Chilano Mateo <[email protected]> wrote:
>> Serguei Spitsyn has updated the pull request incrementally with one >> additional commit since the last revision: >> >> remove trailing spaces from one file > > src/hotspot/share/prims/jvmtiEventController.cpp line 105: > >> 103: static const jlong EXCEPTION_BITS = EXCEPTION_THROW_BIT | >> EXCEPTION_CATCH_BIT; >> 104: static const jlong INTERP_EVENT_BITS = SINGLE_STEP_BIT | >> METHOD_ENTRY_BIT | METHOD_EXIT_BIT | >> 105: FRAME_POP_BIT | FIELD_ACCESS_BIT | >> FIELD_MODIFICATION_BIT; > > I see `can_generate_frame_pop_events` is still used when setting > `JvmtiExport::_can_post_interpreter_events` in > `JvmtiManageCapabilities::update()`. Should we fix that? In that case the > check in `InterpreterMacroAssembler::notify_method_exit` should be > `JvmtiExport::can_post_interpreter_events()` || > `JvmtiExport::can_post_frame_pop`. Thank you for the suggestion. I was also thinking about this kind of inconsistency but considered such a change a little bit risky and intrusive. Let me give it a try. I'll let you know about the progress. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/28407#discussion_r3285885869
