On Tue, 3 Mar 2026 17:14:09 GMT, Chris Plummer <[email protected]> wrote:
>> Yasumasa Suenaga has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Exclude DWARF related code from source list when the build runs on >> unsupported platforms > > make/modules/jdk.hotspot.agent/Lib.gmk line 58: > >> 56: endif >> 57: >> 58: ifeq ($(call isTargetOs, linux)+$(call isTargetCpu, x86_64 aarch64), >> true+true) > > There is an `Or` function in Utils.gmk that you can use here, although I > don't see any examples of it being put to use. I do see "$(call And..." being > used. Thanks! Fixed. > make/modules/jdk.hotspot.agent/Lib.gmk line 63: > >> 61: LIBSAPROC_EXCLUDE_FILES := DwarfParser.cpp dwarf.cpp >> 62: endif >> 63: > > This seems to build fine on riscv64. However, I only have access to the cross > toolchain to build with. I don't have any access to any hosts to test on. > > You might want to work with the various porters to see if the want to get > this working on their ports (riscv64, PowerPC, and s390), and at least test > the current changes to make sure that nothing is currently broken. The only > thing I can do is make sure riscv64 builds. I can't run any tests, and I have > no access to PowerPc and s390 toolchains. Ok, I will ask this to each maillist (ppc-aix-port-dev, riscv-port-dev, s390x-port-dev). ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/29731#discussion_r2881311166 PR Review Comment: https://git.openjdk.org/jdk/pull/29731#discussion_r2881313809
