On Mon, 2 Mar 2026 15:37:30 GMT, Chris Plummer <[email protected]> wrote:

>> Yasumasa Suenaga has updated the pull request incrementally with one 
>> additional commit since the last revision:
>> 
>>   Fix
>
> src/jdk.hotspot.agent/linux/native/libsaproc/ps_core.c line 44:
> 
>> 42: // HWCAP_PACA was introduced in glibc 2.30
>> 43: // 
>> https://sourceware.org/git/?p=glibc.git;a=commit;h=a2e57f89a35e6056c9488428e68c4889e114ef71
>> 44: #if defined(__aarch64__) && !defined(HWCAP_PACA)
> 
> Is the `__arch64__` check needed here? It's not used in the similar code in 
> ps_proc.c.

`HWCAP_PACA` is needed for AArch64 only. Actually the location where is used is 
also enclosed by `#ifdef __aarch64__`.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/29731#discussion_r2875279485

Reply via email to