On Mon, 2 Mar 2026 21:33:13 GMT, Chris Plummer <[email protected]> wrote:
>> Yasumasa Suenaga has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix
>
> src/jdk.hotspot.agent/linux/native/libsaproc/dwarf.hpp line 45:
>
>> 43:
>> 44: DWARF_REGLIST
>> 45: DWARF_PSEUDO_REGLIST
>
> This won't compile on platforms other than x64 and aarch64. Is there a way to
> keep all the other CPU ports building without you having to do a full port to
> each of them?
>
>
> src/jdk.hotspot.agent/linux/native/libsaproc/dwarf.hpp:45:3: error: expected
> '}' before 'DWARF_PSEUDO_REGLIST'
> 45 | DWARF_PSEUDO_REGLIST
> | ^~~~~~~~~~~~~~~~~~~~
> src/jdk.hotspot.agent/linux/native/libsaproc/dwarf.hpp:39:21: note: to match
> this '{'
> 39 | enum DWARF_Register {
Maybe we can avoid this error like following:
#ifndef DWARF_REGLIST
#define DWARF_REGLIST
#endif
#ifndef DWARF_PSEUDO_REGLIST
#define DWARF_PSEUDO_REGLIST
#endif
enum DWARF_Register {
However I wonder why this happen on your environment because cross compiles on
GHA were succeeded:
https://github.com/openjdk/jdk/pull/29731/checks?check_run_id=65356511363
I can apply this change, but I couldn't test because I can't see the error on
GHA.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/29731#discussion_r2875648410
