On Thu, 3 Jul 2025 12:56:44 GMT, Coleen Phillimore <cole...@openjdk.org> wrote:
>> Calvin Cheung has updated the pull request incrementally with one additional >> commit since the last revision: >> >> @coleenp comment > > src/hotspot/share/classfile/modules.cpp line 671: > >> 669: // list[3] = "" >> 670: // list[4] = "" >> 671: list.sort(Modules::compare_module_names); > > Does compare _module_names have to be an external function? I've changed it to a static function in modules.cpp. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/26110#discussion_r2183286022