On Thu, 3 Jul 2025 05:16:54 GMT, Calvin Cheung <cche...@openjdk.org> wrote:
> After the refactoring work done via > [JDK-8280682](https://bugs.openjdk.org/browse/JDK-8280682), there are only > three functions remaining in the ClassLoaderExt class. This RFE is to move > those remaining functions into other classes so that the ClassLoaderExt class > can be eliminated. > > Testing: passed tiers 1 - 5. This looks great. I never liked the Ext name. I had a tiny comment. src/hotspot/share/classfile/modules.cpp line 671: > 669: // list[3] = "" > 670: // list[4] = "" > 671: list.sort(Modules::compare_module_names); Does compare _module_names have to be an external function? ------------- Marked as reviewed by coleenp (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/26110#pullrequestreview-2983066152 PR Review Comment: https://git.openjdk.org/jdk/pull/26110#discussion_r2182718450
