On Thu, 3 Jul 2025 05:16:54 GMT, Calvin Cheung <cche...@openjdk.org> wrote:
> After the refactoring work done via > [JDK-8280682](https://bugs.openjdk.org/browse/JDK-8280682), there are only > three functions remaining in the ClassLoaderExt class. This RFE is to move > those remaining functions into other classes so that the ClassLoaderExt class > can be eliminated. > > Testing: passed tiers 1 - 5. It looks good to me. I like this simplification. But I'm curious what was the original reason to have the `classLoaderExt`? src/hotspot/share/cds/classListParser.cpp line 33: > 31: #include "cds/metaspaceShared.hpp" > 32: #include "cds/unregisteredClasses.hpp" > 33: #include "classfile/classLoader.hpp" Nit: I wonder if the line #33 is really needed and can be removed. ------------- Marked as reviewed by sspitsyn (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/26110#pullrequestreview-2983562923 PR Review Comment: https://git.openjdk.org/jdk/pull/26110#discussion_r2183031189
