On Fri, 27 Jun 2025 19:48:14 GMT, Daniel D. Daugherty <dcu...@openjdk.org>
wrote:
>> src/hotspot/share/prims/jvmtiEnvBase.hpp line 511:
>>
>>> 509: };
>>> 510:
>>> 511: class SetForceEarlyReturnHandshakeClosure : public
>>> JvmtiUnitedHandshakeClosure {
>>
>> I do not support this unification over JVMTI files. This make
>> `HandshakeClosure` class names too long.
>> The JVMTI has a consistent local naming convention to have the suffix
>> `Closure` at the end instead of `HandshakeClosure`. And it is fine because
>> normally there are no other kind of closures in JVMTI code.
>
> Aren't there closures in the JVM/TI tag processing code? I could be
> remembering wrong...
I reverted closure names changes in JVMT files.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/26014#discussion_r2174895464
