On Fri, 27 Jun 2025 16:45:44 GMT, Coleen Phillimore <cole...@openjdk.org> wrote:
> I found a couple of places to realign the parameters, but otherwise this > looks good. I like the new naming conventions. We have a lot of handshakes > now! Were you able to build shenandoah (not built by default, need to add > --enable-jvm-feature-shenandoahgc to configure)? Yes, the code compiles fine with --enable-jvm-feature-shenandoahgc added. > src/hotspot/share/prims/jvmtiEnvBase.hpp line 629: > >> 627: public: >> 628: GetCurrentContendedMonitorHandshakeClosure(JvmtiEnv *env, >> 629: JavaThread* calling_thread, > > Can you realign these parameters? Addressed. > src/hotspot/share/prims/jvmtiEnvBase.hpp line 650: > >> 648: public: >> 649: GetStackTraceHandshakeClosure(JvmtiEnv *env, jint start_depth, jint >> max_count, >> 650: jvmtiFrameInfo* frame_buffer, jint* count_ptr) > > realign parameters. Addressed. > src/hotspot/share/prims/jvmtiEnvBase.hpp line 760: > >> 758: public: >> 759: GetSingleStackTraceHandshakeClosure(JvmtiEnv *env, JavaThread >> *calling_thread, >> 760: jthread thread, jint max_frame_count) > > Also realign parameters. Addressed. > src/hotspot/share/prims/jvmtiEnvBase.hpp line 798: > >> 796: public: >> 797: GetFrameLocationHandshakeClosure(JvmtiEnv *env, jint depth, >> 798: jmethodID* method_ptr, jlocation* >> location_ptr) > > Also realign parameters. Addressed. ------------- PR Comment: https://git.openjdk.org/jdk/pull/26014#issuecomment-3018119426 PR Review Comment: https://git.openjdk.org/jdk/pull/26014#discussion_r2174428232 PR Review Comment: https://git.openjdk.org/jdk/pull/26014#discussion_r2174428418 PR Review Comment: https://git.openjdk.org/jdk/pull/26014#discussion_r2174428575 PR Review Comment: https://git.openjdk.org/jdk/pull/26014#discussion_r2174429046
